Short version:
Open up: APP_Plugins/RJP.MultiUrlPicker/MultiUrlPicker.js and on the bottom (line 116) change dialogService.CloseAll() to dialogService.Close().
Long version:
Firstly, Matt and Lee...WOW! Have been playing with this package and Nested Content last weekend and I'm very impressed. Awesome job and thanks for demoing it on uHangout. #H5YG(uys)R
Secondly, there is a Multi Url Picker property editor from Rasmus John Pedersen. Which is used by quite some people to have a dialog through dialogService to select 1 or more internal Urls or to enter 1 external url. Very handy package. https://our.umbraco.org/projects/backoffice-extensions/multi-url-picker
Unfortunately there is no forum 'attached' to the package, so I could not leave a message behind.
In the uHangout Demo Matt said that basically all property editors are working. That is my experience too so far. Only the Multi Url Picker is not working. The problem is that when you select or enter an Url in the picker it closes the current dialog but it also closes the Doc Type Grid Editor dialog. So all data is lost which you have entered.
I couldn't imagine this has something to do with the Doctype Grid Editor so I had a look at the source code from Multi Url Picker. And I found, that in the MultiUrlPicker angular controller the dialogs are closing with the CloseAll() function. Which it does exactly what the function says ;)
It would be better if the Multi Url Picker developer changes it directly in source but there is not much activity lately on this package (doesn't need to be, it is pretty good as is), but if you are in need/hurry...
Open up: APP_Plugins/RJP.MultiUrlPicker/MultiUrlPicker.js and on the bottom (line 116) change dialogService.CloseAll() to dialogService.Close().
Change one line and this package works also very good with Doc Type Grid Editor! :)
In the uHangout Demo Matt said that basically all property editors are working.
I think I said 99.9% :)
I hit this same issue on a different project and came to the same fix. Ultimately we are somewhat at the whim of other prop editor developers that their solutions use the correct methods, but if nothing else, hopefully more people like yourself are prepaired to dig in and find the fixes so that it's makes a better experience for everyone.
Nice work.
Matt
PS I agree with Lee, it would be great if you felt up to the challenge of submitting a Pull Request.
You are very welcome. It's the least I could do to help somehow make this package as universal as possible.
Right, pull request...are you guys trying to scare me away? xD
Let me put it this way, I'll take a look at that. Never done that before. Let you know how it goes.
@matt
I think I said 99.9% :)
haha, you are right. "basically all" was my interpretation of 99.9%. Hope you can forgive me ;)
Struggling a little with referencing pull request to an issue. But hey, not bad for the first time ;)
Hopefully the (small) change is picked up soon.
PS If you guys give me just a compliment of some sort i'll vote MVP 2015 for you!
Just kidding! Voted already for you. Not gonna say who came first Lee or Matt. Anyway both well deserved in my opinion.
Multi Url Picker not working [And Solution]
Short version: Open up: APP_Plugins/RJP.MultiUrlPicker/MultiUrlPicker.js and on the bottom (line 116) change dialogService.CloseAll() to dialogService.Close().
Long version: Firstly, Matt and Lee...WOW! Have been playing with this package and Nested Content last weekend and I'm very impressed. Awesome job and thanks for demoing it on uHangout. #H5YG(uys)R
Secondly, there is a Multi Url Picker property editor from Rasmus John Pedersen. Which is used by quite some people to have a dialog through dialogService to select 1 or more internal Urls or to enter 1 external url. Very handy package. https://our.umbraco.org/projects/backoffice-extensions/multi-url-picker Unfortunately there is no forum 'attached' to the package, so I could not leave a message behind.
In the uHangout Demo Matt said that basically all property editors are working. That is my experience too so far. Only the Multi Url Picker is not working. The problem is that when you select or enter an Url in the picker it closes the current dialog but it also closes the Doc Type Grid Editor dialog. So all data is lost which you have entered.
I couldn't imagine this has something to do with the Doctype Grid Editor so I had a look at the source code from Multi Url Picker. And I found, that in the MultiUrlPicker angular controller the dialogs are closing with the CloseAll() function. Which it does exactly what the function says ;)
It would be better if the Multi Url Picker developer changes it directly in source but there is not much activity lately on this package (doesn't need to be, it is pretty good as is), but if you are in need/hurry...
Open up: APP_Plugins/RJP.MultiUrlPicker/MultiUrlPicker.js and on the bottom (line 116) change dialogService.CloseAll() to dialogService.Close().
Change one line and this package works also very good with Doc Type Grid Editor! :)
Hi Arjan,
Thanks for reporting this, and pinpointing the issue.
The source-code for the Multi-Url-Picker is up on GitHub, you could raise an issue there?
https://github.com/rasmusjp/umbraco-multi-url-picker/issues
(or if you're feeling adventurous, maybe even a pull-request? no pressure though)
Cheers,
- Lee
I think I said 99.9% :)
I hit this same issue on a different project and came to the same fix. Ultimately we are somewhat at the whim of other prop editor developers that their solutions use the correct methods, but if nothing else, hopefully more people like yourself are prepaired to dig in and find the fixes so that it's makes a better experience for everyone.
Nice work.
Matt
PS I agree with Lee, it would be great if you felt up to the challenge of submitting a Pull Request.
You are very welcome. It's the least I could do to help somehow make this package as universal as possible.
Right, pull request...are you guys trying to scare me away? xD Let me put it this way, I'll take a look at that. Never done that before. Let you know how it goes.
@matt
haha, you are right. "basically all" was my interpretation of 99.9%. Hope you can forgive me ;)
You are forgiven :)
Good luck with the pull request. It's certainly a big milestone, but I'm sure you'll do great.
Keep up the good work.
Matt
I guess it worked out well. Made a pull request. https://github.com/rasmusjp/umbraco-multi-url-picker/pull/29
Struggling a little with referencing pull request to an issue. But hey, not bad for the first time ;) Hopefully the (small) change is picked up soon.
PS If you guys give me just a compliment of some sort i'll vote MVP 2015 for you! Just kidding! Voted already for you. Not gonna say who came first Lee or Matt. Anyway both well deserved in my opinion.
Good work Arjan!
Sure... you have a beautiful smile! ;-)
Pull request accepted (yaaay!) and new version 1.3.1 of Multi Url Picker is released.
So just download and install the latest version: https://our.umbraco.org/projects/backoffice-extensions/multi-url-picker
Congrats! You helped make it happen! #h5yr
is working on a reply...